MRG, BUG: Fix interactive update of mapping#8985
Merged
GuillaumeFavelier merged 7 commits intomne-tools:mainfrom Mar 4, 2021
Merged
MRG, BUG: Fix interactive update of mapping#8985GuillaumeFavelier merged 7 commits intomne-tools:mainfrom
GuillaumeFavelier merged 7 commits intomne-tools:mainfrom
Conversation
Contributor
|
we could check that |
Member
Author
Great idea, pushed. Will merge and backport once CIs come back happy |
Member
Author
|
Okay I fought through a bit of a nightmare with control flow with LUT updates. Now:
This also makes interaction smoother for me, which is nice. Ready for review/merge from my end @GuillaumeFavelier, hopefully CIs come back happy with this one... |
Member
Author
|
Actually I think I realized a simpler pattern, will implement it tomorrow |
Member
Author
|
Okay @GuillaumeFavelier should be good to go here |
GuillaumeFavelier
approved these changes
Mar 4, 2021
Contributor
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
LGTM, it is indeed very snappy now 👍
Contributor
|
Thanks @larsoner ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
main:Peek.2021-03-03.12-05.mp4
On this PR:
Peek.2021-03-03.12-05_2.mp4
I don't know a good wait to test this on CIs unfortunately since it has to do with actual rendering.