MRG, ENH: Better float slider spacing and interaction#8975
MRG, ENH: Better float slider spacing and interaction#8975larsoner merged 9 commits intomne-tools:mainfrom
Conversation
|
I hope you don't mind @larsoner, I pushed a commit to port |
|
Yes that's great! Next I think I'll change |
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
I restarted Azure but it seems to be stuck at the dependencies step. I don't think it's related.
* upstream/main: MAINT: Revert conda azure change (mne-tools#8978) make large rotation penalty optional in chpi function (mne-tools#8770) Fix: Wrong channel-adjacency-matrix for Neuromag122 (mne-tools#8891) [MRG] Add optional different ways of averaging EpochsTFR (mne-tools#8879) DOC, STY: fix dataframe scrolling (mne-tools#8977)
hoechenberger
left a comment
There was a problem hiding this comment.
Awesome! If @GuillaumeFavelier is happy, this should be good to merge
QLineEditin favor ofQDoubleSpinBoxwith a sensible step. Automagically fixes spacing issues and makes things more compact and usable (default step is 1/20th of the limits, which works well in testing). Also usesetKeyboardTracking(False)to avoid needing to update until enter is pressed.mousePressEventhandling to QFloatSlider so that when you click somewhere specific on the slider, you jump to that point.QFloatSliderfor the time axis so that non-integral time points can be used, which is the way it was before and is especially useful when using non-nearest-neighbor interp (doesn't seem to hurt nearest-neighbor use cases because you still see it "snap" on changes, and has the advantage of jump-to-location on click).@GuillaumeFavelier can you try it and see what you think?
main:main.mp4
this PR:
spacing.mp4