[MRG] Fix ica.plot_sources exception#8967
Conversation
|
Just a heads up that the pip 3.9 and pip pre builds are broken currently, feel free to ignore them |
|
Looks like this does not actually fix the problem: I'll take a closer look. |
|
The example looks correct now: https://25473-1301584-gh.circle-artifacts.com/0/dev/auto_examples/preprocessing/plot_run_ica.html#sphx-glr-auto-examples-preprocessing-plot-run-ica-py But I don't think the change to the test file is actually testing what we want it to, so don't merge until after I've updated that (off to a meeting now) |
|
Sorry I should have been clearer. My commits were intended to just fix the behavior in the PR description and in the test, not the issue opened (#8966). Your commits seem to close that issue as well. Thanks! |
I think this was a case of me not reading carefully enough :) Anyway I think now both problems are fixed. |
|
thanks @bloyl ! |
What does this implement/fix?
would raise an exception.
RuntimeError: bad channel(s) ['ICA000'] marked do not exist in infoAlso fixed a typo in ctf.io
I don't think either of these have made it to release so no whats new.
closes #8966