Conversation
|
I think it's worth restarting the CIs, even though |
| with _qt_disable_paint(self.plotter): | ||
| with self._ensure_minimum_sizes(): | ||
| self.show() | ||
| self._update() |
There was a problem hiding this comment.
This will only happen if we call setup_time_viewer, which only happens if time_viewer=True (effectively) is used, right? This suggests that if time_viewer=False then the bug will still be there. It seems like we Probably need an equivalent change in very similar code in _pyvista.py, or some other fix, or maybe this belongs at the Brain level?
There was a problem hiding this comment.
You're totally right. And this code in Brain can be removed since self.show() calls self._renderer.show(). I'll update on _pyvista
There was a problem hiding this comment.
... and cannot be removed since ensure_minimum_size has a different version for Brain.
|
This is ready on my end. |
|
Thanks @GuillaumeFavelier |
Locally I was able to reproduce #8757 (comment) and this small fix did the trick for me. Let's see how it is on Circle.