MRG, FIX: Brain add/remove labels#8820
Merged
larsoner merged 4 commits intomne-tools:mainfrom Feb 1, 2021
Merged
Conversation
larsoner
approved these changes
Feb 1, 2021
Contributor
Author
|
This is better I think @jasmainak
|
Contributor
Author
|
I added some commits to fix color and unnamed labels and improve tests. |
86 tasks
jasmainak
approved these changes
Feb 1, 2021
Member
jasmainak
left a comment
There was a problem hiding this comment.
Perfect, thanks for the fix!
Member
|
Thanks @GuillaumeFavelier ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in
remove_labels()preventing it to have any effect. I also updated the tests to avoid regression.Closes #8815