[WIP] Add transparency to plot_alignment #8446
Conversation
|
@kdoelling1919 let me know once you've checked the outputs and they look okay (bonus points if you paste CircleCI links here so that it's easier for me to look, too). Other than one minor gripe, LGTM. @GuillaumeFavelier what would it take to add a |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
Looks good except for now you can see one of the depth electrodes didn't really hit the brain... Other tutorials that used plot_alignment seem to be in tact. |
|
Here's what it looks in current version The only difference is that I added the pial surface to show that it can be done with the transparency. It looks fine to me but maybe could be improved by changing the viewing angle? |
|
|
||
| Enhancements | ||
| ~~~~~~~~~~~~ | ||
| - Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`)) |
There was a problem hiding this comment.
| - Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`)) | |
| - Update ``surfaces`` argument in :func:`mne.viz.plot_alignment` to allow dict for transparency values, and set default for sEEG data to have transparency (by `Keith Doelling`_ (:gh:`8445`) |
But we can fix this later, we're probably reformatting all of these lines within this release anyway
|
Thanks @kdoelling1919 ! |
|
great success! Thanks to everyone! |
Reference issue
Issue #8445
What does this implement/fix?
Reduce maximum alpha to be 0.75 in plot_alignment to aid viewing of electrodes inside the brain and skull (mostly sEEG). Also edits a few tutorials to see the new outputs of circleCI
Additional information
The goal currently is to see how these look in the tutorial examples so that we can decide whether this is the best strategy or to use an autodetect (of whether sensors are inside the surface) method instead.