Skip to content

Backport: Fix backend='pyvista' in stc.plot() (#8395)#8417

Merged
agramfort merged 1 commit intomne-tools:maint/0.21from
hoechenberger:backport-8395
Oct 24, 2020
Merged

Backport: Fix backend='pyvista' in stc.plot() (#8395)#8417
agramfort merged 1 commit intomne-tools:maint/0.21from
hoechenberger:backport-8395

Conversation

@hoechenberger
Copy link
Copy Markdown
Member

@hoechenberger hoechenberger commented Oct 23, 2020 •
edited
Loading

No description provided.

@hoechenberger hoechenberger changed the title Fix backend='pyvista' in stc.plot() (#8395) Backport: Fix backend='pyvista' in stc.plot() (#8395) Oct 23, 2020
@hoechenberger
Copy link
Copy Markdown
Member Author

hoechenberger commented Oct 23, 2020

I'm not sure why the notebook test fails… @GuillaumeFavelier mind having a look?

@agramfort agramfort merged commit 74041b7 into mne-tools:maint/0.21 Oct 24, 2020
@hoechenberger
Copy link
Copy Markdown
Member Author

hoechenberger commented Oct 24, 2020

@agramfort One test failed, yet you merged this PR – was this intentional or an accident?

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Oct 24, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

GuillaumeFavelier commented Oct 24, 2020

Yes. But it's just a small thing. On maint/0.21.0 the attribute name is _notebook (with an underscore) instead of just notebook

@hoechenberger
Copy link
Copy Markdown
Member Author

hoechenberger commented Oct 24, 2020

@GuillaumeFavelier

Yes. But it's just a small thing. On maint/0.21.0 the attribute name is _notebook (with an underscore) instead of just notebook

But this PR didn't touch any of these… I don't get it. But you seem to be understanding what's going on :) I'd appreciate if you could file a follow-up PR if something is broken now? Or we can have a quick chat / call and you tell me what I need to fix :)
btw check your Slack! ;)

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Oct 24, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

GuillaumeFavelier commented Oct 24, 2020

But this PR didn't touch any of these…

The tests use the name 😅

I will open a PR that reverts to the old name and we backport it too. What do you say?

@hoechenberger
Copy link
Copy Markdown
Member Author

hoechenberger commented Oct 24, 2020 •
edited
Loading

I will open a PR that reverts to the old name and we backport it too. What do you say?

perfect :) file the PR against the maint/0.21 branch directly

@hoechenberger hoechenberger deleted the backport-8395 branch October 24, 2020 08:55
@hoechenberger hoechenberger mentioned this pull request Oct 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoechenberger @agramfort @GuillaumeFavelier