WIP: verbose -> keyword-only arg in apply_baseline#8263
WIP: verbose -> keyword-only arg in apply_baseline#8263hoechenberger wants to merge 1 commit intomne-tools:masterfrom
Conversation
| vars_ = vars(self) | ||
| if 'kwonlyargs' in vars_: | ||
| vars_['signature'] = vars_['signature'].replace('*, ', '') | ||
| src = src_templ % vars_ |
There was a problem hiding this comment.
In general we try just to vendor this rather than make our own updates, so we should check to see if an updated version of https://github.com/micheles/decorator/blob/master/src/decorator.py will do what we want
There was a problem hiding this comment.
So this is what happens when you don't check a file's entire path, and only look at its base name. 🤦♂️
There was a problem hiding this comment.
Which functionality from this package do we use that's not already in Python's standard library?
There was a problem hiding this comment.
IIRC mostly the verbose decorator needs it to preserve traceback information properly. It's possible it's outdated for Python 3.6+, not sure
There was a problem hiding this comment.
I've checked with the latest decorator release and the problem persists.
Reference issue
Addresses part of #8258
@larsoner I didn't have much time tonight and this is how far I got. Feel free to bring this one home in time for 0.21; I probably won't have time to give it any more love before the weekend.