MRG, MAINT: Update PyVista backend#7513
Closed
larsoner wants to merge 2 commits intomne-tools:masterfrom
Closed
Conversation
Member
Author
|
@GuillaumeFavelier this breaks it! I'll try removing the AA stuff and see if that fixes things |
Contributor
|
+1 for testing AA |
Codecov Report
@@ Coverage Diff @@
## master #7513 +/- ##
==========================================
- Coverage 85.72% 8.06% -77.67%
==========================================
Files 453 438 -15
Lines 82758 80714 -2044
Branches 13062 13026 -36
==========================================
- Hits 70947 6512 -64435
- Misses 9137 74168 +65031
+ Partials 2674 34 -2640 |
Member
Author
|
Okay @GuillaumeFavelier pushed a commit that hopefully will "fix" things for us |
This was referenced Mar 25, 2020
Member
Author
|
I'll kill these CIs for now and if the fix doesn't work, keep iterating here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this part of #7060 breaks Azure.