Skip to content

Use _time_interp_funcs in _interpolate_data#7462

Merged
larsoner merged 2 commits intomne-tools:masterfrom
GuillaumeFavelier:fix_brain_interpolate_data
Mar 17, 2020
Merged

Use _time_interp_funcs in _interpolate_data#7462
larsoner merged 2 commits intomne-tools:masterfrom
GuillaumeFavelier:fix_brain_interpolate_data

Conversation

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

This PR fixes the recent issues with Circle. For short, _interpolate_data() now uses _time_interp_funcs

Reference: #7257 (comment)

@larsoner
Copy link
Copy Markdown
Member

Can you touch at least one of the broken examples so that we can verify the fix?

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2020

Codecov Report

Merging #7462 into master will decrease coverage by 2.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7462      +/-   ##
==========================================
- Coverage   90.05%   87.61%   -2.45%     
==========================================
  Files         454      454              
  Lines       82523    82558      +35     
  Branches    13043    13050       +7     
==========================================
- Hits        74320    72331    -1989     
- Misses       5367     7425    +2058     
+ Partials     2836     2802      -34

@larsoner
Copy link
Copy Markdown
Member

CircleCI is fixed so I'll merge. It looks like something else has broken most of our other CIs

@larsoner larsoner merged commit 8ac813c into mne-tools:master Mar 17, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the fix_brain_interpolate_data branch June 11, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants