handle _Brain size gracefully with pyvista#7435
Merged
GuillaumeFavelier merged 4 commits intomne-tools:masterfrom Mar 13, 2020
Merged
handle _Brain size gracefully with pyvista#7435GuillaumeFavelier merged 4 commits intomne-tools:masterfrom
GuillaumeFavelier merged 4 commits intomne-tools:masterfrom
Conversation
GuillaumeFavelier
approved these changes
Mar 12, 2020
Contributor
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
LGTM @drammock, thanks for taking care of it
Contributor
|
Any idea why the CIs are not happy? |
Contributor
|
Nevermind. This has been reported in Teemu/pytest-sugar#187 |
424948f to
7964494
Compare
Member
Author
|
@GuillaumeFavelier this has been rebased with the pytest-sugar fix, ready to go when CIs are green. |
Codecov Report
@@ Coverage Diff @@
## master #7435 +/- ##
==========================================
+ Coverage 89.97% 90.12% +0.14%
==========================================
Files 454 454
Lines 82322 81499 -823
Branches 13022 13020 -2
==========================================
- Hits 74073 73450 -623
+ Misses 5409 5220 -189
+ Partials 2840 2829 -11 |
Contributor
|
Thanks @drammock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7426
Also removes
u"at beginning of docstrings in the edited file.It turns out that
pysurfer.Braindoesn't really check size at all:https://github.com/nipy/PySurfer/blob/master/surfer/viz.py#L557-L561
So I just did what seemed sensible to me.