Conversation
Codecov Report
@@ Coverage Diff @@
## master #7342 +/- ##
==========================================
- Coverage 89.99% 89.94% -0.06%
==========================================
Files 450 450
Lines 80659 81587 +928
Branches 12943 13003 +60
==========================================
+ Hits 72589 73382 +793
- Misses 5244 5385 +141
+ Partials 2826 2820 -6 |
ae05de8 to
3a14166
Compare
|
|
No, it defines its own |
|
Hah! fair enough |
Co-Authored-By: Daniel McCloy <dan@mccloy.info>
larsoner
left a comment
There was a problem hiding this comment.
LGTM +1 for merge once CIs come back happy
|
Good call! run_ica has been some historical leftover for years ...
… On 19 Feb 2020, at 21:23, Eric Larson ***@***.***> wrote:
@larsoner approved this pull request.
LGTM +1 for merge once CIs come back happy
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
The Travis failure is a general timeout error at the CodeCov step, seems unrelated to this PR (@larsoner have you seen that before? Seems odd). Azure is "Windows fatal exception: caccess violation" which is also unrelated (though is happening a lot lately, should be investigated). |
|
@drammock the Travis timeouts at various stages are just numpy/numpy#15580 The Azure failures I was hoping to fix with #7295 but hasn't quite done the trick |
* Deprecate Deprecate mne.preprocessing.run_ica() * Update mne/preprocessing/tests/test_ica.py Co-Authored-By: Daniel McCloy <dan@mccloy.info> * Refactor tests * Update docstring Co-authored-by: Daniel McCloy <dan@mccloy.info>
* Deprecate Deprecate mne.preprocessing.run_ica() * Update mne/preprocessing/tests/test_ica.py Co-Authored-By: Daniel McCloy <dan@mccloy.info> * Refactor tests * Update docstring Co-authored-by: Daniel McCloy <dan@mccloy.info>
What does this implement/fix?
Removes themne.preprocessing.ica.run_ica()function. All it does it instantiate anICAobject and then run an artifact detection. However, the same can be achieved by usingICA.detect_artifacts().Deprecates
mne.preprocessing.ica.run_ica()in favor ofICA.detect_artifacts()