Skip to content

DOC: adds noise covariance to glossary#6875

Merged
larsoner merged 4 commits intomne-tools:masterfrom
mohdsherif:glossary-noiseCov
Oct 3, 2019
Merged

DOC: adds noise covariance to glossary#6875
larsoner merged 4 commits intomne-tools:masterfrom
mohdsherif:glossary-noiseCov

Conversation

@mohdsherif
Copy link
Copy Markdown
Contributor

@jasmainak Can you review?

Thanks.

@drammock drammock mentioned this pull request Oct 1, 2019
11 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 2, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@affc685). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6875   +/-   ##
=========================================
  Coverage          ?   89.55%           
=========================================
  Files             ?      426           
  Lines             ?    76074           
  Branches          ?    12415           
=========================================
  Hits              ?    68127           
  Misses            ?     5156           
  Partials          ?     2791

@mohdsherif
Copy link
Copy Markdown
Contributor Author

@agramfort Can you please review? Thanks.

Copy link
Copy Markdown
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides these indent issues LGTM !

thx @mohdsherif

@mohdsherif
Copy link
Copy Markdown
Contributor Author

I rebased and force pushed to resolve the conflict @agramfort. Please review.

@larsoner larsoner merged commit 70bf11c into mne-tools:master Oct 3, 2019
@larsoner
Copy link
Copy Markdown
Member

larsoner commented Oct 3, 2019

Thanks @mohdsherif !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants