Skip to content

Add montage parameter to BaseRaw#6462

Closed
massich wants to merge 1 commit intomne-tools:masterfrom
massich:add_montage_to_baseraw
Closed

Add montage parameter to BaseRaw#6462
massich wants to merge 1 commit intomne-tools:masterfrom
massich:add_montage_to_baseraw

Conversation

@massich
Copy link
Copy Markdown
Contributor

@massich massich commented Jun 17, 2019

This PR adds montage parameter in BaseRaw

@massich massich force-pushed the add_montage_to_baseraw branch from b5a8ad9 to 5531dd4 Compare June 17, 2019 12:00
@massich
Copy link
Copy Markdown
Contributor Author

massich commented Jun 17, 2019

So far this PR does something really dummy. It takes info[dig] which has been populated by _read_raw_file with a Digitization object and re-assigns it to info['dig'].

But this already raises some questions:
1 - who should have the set_montage responsibility? IMHO it should exposed through raw object (from channels mixin as it is it's fine), but it should be done in meas_info. Right now is done in montage.

2 - how can I separate to get 'dig' from the info reading in here:

info, meas = read_meas_info(fid, tree, clean_bads=True)

cc: @agramfort, @larsoner

@massich massich mentioned this pull request Jun 17, 2019
19 tasks
@agramfort
Copy link
Copy Markdown
Member

not the route we decided to follow

@agramfort agramfort closed this Jun 21, 2019
@massich massich deleted the add_montage_to_baseraw branch June 26, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants