MRG: use doccer to fill docstrings#5921
Merged
larsoner merged 3 commits intomne-tools:masterfrom Feb 13, 2019
Merged
Conversation
larsoner
commented
Feb 11, 2019
Member
Author
|
This pull request introduces 2 alerts when merging 650b1b8 into d54144f - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Member
|
So far so good on my side |
Contributor
|
Great +10000 |
Codecov Report
@@ Coverage Diff @@
## master #5921 +/- ##
==========================================
+ Coverage 88.7% 88.71% +0.01%
==========================================
Files 399 399
Lines 72139 72224 +85
Branches 12098 12134 +36
==========================================
+ Hits 63989 64074 +85
- Misses 5214 5215 +1
+ Partials 2936 2935 -1 |
Member
Author
|
@agramfort okay to merge once CI's are happy? Then I can finish |
Member
|
I like it a lot 👍 |
Member
Author
|
Because there is a failing test I need to fix |
Member
Author
|
This pull request introduces 2 alerts when merging affac11 into 7856133 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
agramfort
reviewed
Feb 12, 2019
agramfort
reviewed
Feb 12, 2019
agramfort
reviewed
Feb 12, 2019
agramfort
reviewed
Feb 12, 2019
Member
|
@agramfort <https://github.com/agramfort> okay to merge once CI's are
happy? Then I can finish rank and picks PRs.
yes
|
Member
Author
|
This pull request introduces 2 alerts when merging 6a9fbee into fd91ebe - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Member
Author
|
Travis error is spurious download error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept for #5753. Done:
decorator.pyto get any bugfixesverbosedecorator itself to be a docfillerepochs.pyandsource_estimate.py.Posting to get comments before I replace the remaining 334 (!) instances of
verbose :in our codebase.Closes #5753.