Ignore event_offset in cnt when no events exist.#4520
Merged
agramfort merged 1 commit intomne-tools:masterfrom Sep 6, 2017
Merged
Ignore event_offset in cnt when no events exist.#4520agramfort merged 1 commit intomne-tools:masterfrom
agramfort merged 1 commit intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4520 +/- ##
==========================================
+ Coverage 83.44% 83.59% +0.15%
==========================================
Files 349 349
Lines 65212 65216 +4
Branches 10083 10085 +2
==========================================
+ Hits 54414 54517 +103
+ Misses 7945 7843 -102
- Partials 2853 2856 +3 |
Member
|
Would it be possible to have a test? Can you update what's new? |
Member
|
@jaeilepp did you try on the problematic file ? how do you know it works? |
Contributor
Author
|
Yeah, I have the problematic file. It's 2GB. The event_offset field in the file header was a negative value. Rest of the header seems okay. |
Member
|
ok let's say it works then... |
Member
|
thx @jaeilepp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. mailing list.
Adding a test would require adding a small file which I don't have.