Skip to content

Revert change to sphere="auto"#13405

Merged
larsoner merged 1 commit intomne-tools:mainfrom
wmvanvliet:revert
Sep 3, 2025
Merged

Revert change to sphere="auto"#13405
larsoner merged 1 commit intomne-tools:mainfrom
wmvanvliet:revert

Conversation

@wmvanvliet
Copy link
Copy Markdown
Contributor

Revert the change in default behavior when sphere="auto" from #13400

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Sep 2, 2025

Should we add support for an mode="robust" or something that does what you originally proposed? That way people can get the enhanced functionality if they want

@wmvanvliet
Copy link
Copy Markdown
Contributor Author

wmvanvliet commented Sep 2, 2025

Nah, this is for edge cases anyway, and for that being able to set sphere to anything you want is good enough IMO. The previous change to "auto" was to make it "just work" for a little more cases. But it's not worth breaking someones maxfilter or fieldlines plot over.

@larsoner larsoner merged commit 07a63fd into mne-tools:main Sep 3, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants