Skip to content

Bump Github VM MacOS-13 -> MacOS-14#13396

Merged
larsoner merged 6 commits intomne-tools:mainfrom
scott-huberty:update_mac_runners
Aug 28, 2025
Merged

Bump Github VM MacOS-13 -> MacOS-14#13396
larsoner merged 6 commits intomne-tools:mainfrom
scott-huberty:update_mac_runners

Conversation

@scott-huberty
Copy link
Copy Markdown
Contributor

@scott-huberty scott-huberty commented Aug 26, 2025

Reference issue (if any)

closes #13388

What does this implement/fix?

Now our tests will run against MacOS Sonoma and MacOS Sequoia, both on apple silicone architectures. I selected MacOS-14 based on the listed available runners here

Additional information

Github, Python (I think), and Apple itself are deprecating support for Intel Macs.

@scott-huberty
Bump Github VM MacOS-14 -> MacOS-14
dfe53eb 
Github, Python, and Apple itself are deprecating support for Intel Macs:

https://github.blog/changelog/2025-07-11-upcoming-changes-to-macos-hosted-runners-macos-latest-migration-and-xcode-support-policy-updates/#macos-13-is-closing-down

Now our tests will run against MacOS Sonoma and MacOS Sequoia, both on applie silicone architectures
@scott-huberty scott-huberty changed the title Bump Github VM MacOS-14 -> MacOS-14 Bump Github VM MacOS-13 -> MacOS-14 Aug 26, 2025
larsoner
larsoner approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking for merge-when-green, thanks in advance @scott-huberty !

Will require an adjustment to our merge protection rules, which I'll make after the CIs come back green

@larsoner larsoner enabled auto-merge (squash) August 26, 2025 20:37
@larsoner
Copy link
Copy Markdown
Member

larsoner commented Aug 27, 2025

@scott-huberty I wasn't sure why Windows was timing out here. Comparing the GHA logs between the runs here and one that was green a couple of days ago I couldn't find any meaningful differences. I realized we might as well test Python 3.11 and 3.12 somewhere anyway, so I bumped a couple of jobs up from the min 3.10. It looks like it's working. I'm guessing there have been some changes to the conda packages for 3.10 that cause the solver to have issues, and changing the Python version magically fixes things. This sort of thing can happen with conda sometimes 😢

Anyway, hopefully this will land today 🤞 No action needed from your end

@scott-huberty
Copy link
Copy Markdown
Contributor Author

scott-huberty commented Aug 27, 2025

@scott-huberty I wasn't sure why Windows was timing out here. Comparing the GHA logs between the runs here and one that was green a couple of days ago I couldn't find any meaningful differences. I realized we might as well test Python 3.11 and 3.12 somewhere anyway, so I bumped a couple of jobs up from the min 3.10. It looks like it's working. I'm guessing there have been some changes to the conda packages for 3.10 that cause the solver to have issues, and changing the Python version magically fixes things. This sort of thing can happen with conda sometimes 😢

Anyway, hopefully this will land today 🤞 No action needed from your end

Makes sense - thanks!

@larsoner larsoner merged commit 0836e42 into mne-tools:main Aug 28, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

No one assigned

Labels

no-changelog-entry-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intel MacOS GitHub runner is being deprecated

2 participants

@scott-huberty @larsoner