BUG: Fix bug with anonymization#12967
Merged
larsoner merged 2 commits intomne-tools:mainfrom Nov 14, 2024
Merged
Conversation
drammock
approved these changes
Nov 14, 2024
Member
drammock
left a comment
There was a problem hiding this comment.
looks reasonable! Seems like you missed a needs-testing-data decorator somewhere:
=========================== short test summary info ============================
FAILED mne/io/fiff/tests/test_raw_fiff.py::test_fif_files[fname0] - FileNotFoundError: fname does not exist: "/home/runner/work/mne-python/mne-python/SSS/test_move_anon_raw.fif"
FAILED mne/io/fiff/tests/test_raw_fiff.py::test_fif_files[fname1] - FileNotFoundError: fname does not exist: "/home/runner/work/mne-python/mne-python/SSS/TRIUX/triux_bmlhus_erm_raw.fif"
= 2 failed, 2224 passed, 1385 skipped, 60 deselected, 8 xfailed in 750.10s (0:12:30) =
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12963
Within-cycle fix so no need for changelog entry.
Our anonymization tests were a bit lacking so changes ended up being a bit bigger than I expected.