Fix unit handling for µV and parsing of birthday in ANT format#12933
Merged
mscheltienne merged 3 commits intomne-tools:mainfrom Oct 31, 2024
Merged
Fix unit handling for µV and parsing of birthday in ANT format#12933mscheltienne merged 3 commits intomne-tools:mainfrom
mscheltienne merged 3 commits intomne-tools:mainfrom
Conversation
larsoner
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of fixes thanks to a problematic file shared by ANT's support which go with mscheltienne/antio@2140628 and mscheltienne/antio@05e5ebb
I didn't add any tests in
antiofor now as this file was strange with birthday partially set, sex set to[, and with this encoding issue that needs more attention/information for now.