[BUG] Fix ignored colorbar flag in plot_psds_topomap()#12853
Merged
drammock merged 3 commits intomne-tools:mainfrom Sep 18, 2024
Merged
[BUG] Fix ignored colorbar flag in plot_psds_topomap()#12853drammock merged 3 commits intomne-tools:mainfrom
colorbar flag in plot_psds_topomap()#12853drammock merged 3 commits intomne-tools:mainfrom
Conversation
drammock
approved these changes
Sep 18, 2024
Member
drammock
left a comment
There was a problem hiding this comment.
just one FYI / nitpick, I'll go ahead and merge since it's debatable if it's an improvement in this case.
Comment on lines
+573
to
+575
| raw = read_raw_fif(raw_fname) | ||
| picks = pick_types(raw.info, meg="grad") | ||
| info = pick_info(raw.info, picks) |
Member
There was a problem hiding this comment.
[nitpick/FYI]: there is mne.io.read_info(raw_fname) for cases where you don't need the actual raw data. Here you need picks too, so you'd also need mne.channel_indices_by_type() so in the end it's not any shorter:
Suggested change
| raw = read_raw_fif(raw_fname) | |
| picks = pick_types(raw.info, meg="grad") | |
| info = pick_info(raw.info, picks) | |
| info = read_info(raw_fname) | |
| picks = channel_indices_by_type(info)["grad"] | |
| info = pick_info(info, picks) |
and you might need to add from mne.io import read_info and from mne import channel_indices_by_type to the top of the file.
Contributor
Author
There was a problem hiding this comment.
Good point, will keep this in mind!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #12852
What does this implement/fix?
Stops
colorbar=Falsefrom being overwritten inplot_psds_topomap()(and also in e.g.,*Spectrum.plot_topomap()which calls it).Additional information
Also includes a small unit test to check the
colorbarflag isn't ignored.