FIX: use meters for pupil SI, not moles#12850
Conversation
|
OK, trying to establish some good scalings. If I simulate some pupil data ranging from 0 - 8mm and plot, I get this:
@sappelhoff do you have the bandwidth to try this branch out with your eyetracking data? |
|
great, thanks scott! |
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
doc/changes/devel/12850.bugfix.rst
Outdated
There was a problem hiding this comment.
This is a within-release bugfix, so a changelog entry is actually not needed (and even has the potential to cause slight confusion --- we don't want people unnecessarily worrying about wrong axes labels if they're upgrading from stable-to-stable versions, which is the assumption we make of our changelog readers). @scott-huberty once the CIs have finished running, please add no-changelog-entry-needed label, then delete this file and push with ci-skip in the commit msg (no need to re-run them for just a deleted changelog entry). Then ping me; I'll do a manual merge.
There was a problem hiding this comment.
@drammock done. However AFAICT I can't add any labels to this PR, you might have to do it on my behalf.
There was a problem hiding this comment.
@drammock Also just a heads up that the pip-pre jobs didn't pass the last time the CI's ran. The failures were in the decoding module: https://dev.azure.com/mne-tools/mne-python/_build/results?buildId=31286&view=logs&j=dded70eb-633c-5c42-e995-a7f8d1f99d91&t=1ccededa-7e7e-5a92-87ce-e531d760d025





fixes #12849
I actually need to simulate some pupil data in meters and test this plotting function to see if the scalings make sense (we probably need to adjust them).