Merged
Conversation
Member
|
Happy to follow ruff's rules. |
Member
|
the | operator only works for Python 3.10+ IIRC otherwise we need a future import i'm happy to see the change in any case |
Member
|
works for me if it passes our minimal dep python version. |
Member
Author
|
We will require 3.10+ in the next release so we should be good. Ruff was actually smart enough to use our |
Member
|
+1
… Message ID: ***@***.***>
|
Member
|
Great! |
hoechenberger
approved these changes
Aug 19, 2024
drammock
approved these changes
Aug 19, 2024
sappelhoff
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
isinstance(x, (a, b))intoisinstance(x, a | b).I guess we need to decide if we actually want this first. But I'm happy to follow
ruff's lead/opinion on what's best style practice.Once merged we should add to
.git-blame-ignore-revs.