Skip to content

ENH: Use date and datetime objects#12720

Merged
hoechenberger merged 4 commits intomne-tools:mainfrom
larsoner:bday
Jul 17, 2024
Merged

ENH: Use date and datetime objects#12720
hoechenberger merged 4 commits intomne-tools:mainfrom
larsoner:bday

Conversation

@larsoner
Copy link
Copy Markdown
Member

  1. Use datetime.date for info["subject_info"]["birthday"] rather than a year/month/day tuple
  2. Use datetime.datetime for info["helium_info"]["meas_date"]
  3. Fix in-memory anonymization for EDF by deleting edf_info["subject_info"] and edf_info["meas_date"]

Closes #11966
Closes #11327

@larsoner larsoner added this to the 1.8 milestone Jul 16, 2024
@larsoner
Copy link
Copy Markdown
Member Author

Thanks for the quick reviews, should be good now!

@hoechenberger hoechenberger merged commit e299f1e into mne-tools:main Jul 17, 2024
@hoechenberger
Copy link
Copy Markdown
Member

thanks Eric, very nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: raw.anonymize() not fully anonymizing info['subject_info']['birthday'] should support a datetime object

5 participants