don't rely on inst_type to triage class constructors#12514
Merged
larsoner merged 1 commit intomne-tools:mainfrom Mar 25, 2024
Merged
don't rely on inst_type to triage class constructors#12514larsoner merged 1 commit intomne-tools:mainfrom
larsoner merged 1 commit intomne-tools:mainfrom
Conversation
larsoner
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12512
The bug was relying on
TFR._inst_typewhen deciding which class constructor to use when reading from file. The problem was that AverageTFRs might have an_inst_typeofEpochs(which is itself OK / not a bug, we want to know for thereprthat the TF estimates were done on Epochs and then averaged afterwards).new test fails on main and passes here (locally at least!)