Some improvements to EvokedField#12070
Closed
wmvanvliet wants to merge 8 commits intomne-tools:mainfrom
Closed
Conversation
foreground and background color parameters to EvokedFieldEvokedField
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text labels would always be drawn in white before. This is problematic when using a white background color in the EvokedField figure (which looks good so is something you would want to do).
Also adds a slider to control the thickness of the contour lines. On high resolution screens they may be too thin, and in some other cases, for example when there are lots of things drawn on top of each other, you want the contour lines to stand out more.