harmonize plot_psd() and compute_psd().plot() #11418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
commented
Jan 13, 2023
drammock
commented
Jan 19, 2023
| freq_idx = np.sort([np.argmin(np.abs(freqs_sim - f)) | ||
| for f in hpi_freqs]) | ||
| # bins closest to cHPI freqs should have very high energy in MEG chans | ||
| if picks is picks_meg: |
Member
Author
There was a problem hiding this comment.
incidentally, since #4322 this conditional was never getting hit because picks_meg was all MEG picks, but that PR changed picks to be just the first 3 entries of it.
Member
Author
|
pip-pre CIs will fail until scipy/scipy#17811 is resolved (a consequence of the fix to numpy/numpy#23032) |
Member
|
Thanks @drammock ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11343