MAINT: Matplotlib 3.7 compat#11417
Merged
drammock merged 2 commits intomne-tools:mainfrom Jan 12, 2023
Merged
Conversation
drammock
approved these changes
Jan 12, 2023
Member
drammock
left a comment
There was a problem hiding this comment.
nice job of leaving breadcrumbs for things that need to still be fixed.
| @@ -74,14 +76,10 @@ def test_theme_colors(pg_backend, theme, monkeypatch, tmp_path): | |||
| return # we could add a ton of conditionals below, but KISS | |||
| is_dark = _qt_is_dark(fig) | |||
| # on Darwin these checks get complicated, so don't bother for now | |||
Member
There was a problem hiding this comment.
Suggested change
| # on Darwin these checks get complicated, so don't bother for now |
comment no longer relevant, you removed the if != Darwin line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to upgrade to latest
matplotlibdev today and hit a bunch of failures (in addition to #11332). This PR aims to restore our--pretesting of matplotlib, decorating withxfailif needed (e.g., for button-related tests). This seems better than sticking with<3.7, which will continue to allow us to accumulate more incompatibilities in addition to the button one.Also fixes (hopefully) the theme testing, which was broken for me on Ubuntu 22.10 on a dark theme.
Mostly complementary with #11409, which hopefully will be an easy rebase/merge after this PR is in and can remove some
xfails.