[ENH, MRG] Add decimate to EpochsTFR object #10940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Jul 21, 2022
Member
|
@drammock maybe merge if happy? 🙏 @alexrockhill ! |
drammock
approved these changes
Jul 21, 2022
4 tasks
Contributor
Author
|
I didn't fix checking for aliasing which doesn't apply to |
Member
ah, dang. yes, please pull that out in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes memory failures here #10920.
I just needed the decimate method but while I was changing that, it made sense to add in
tminandtmaxand to maktimesreadonly as inEpochs.