First pass at get_decimated_surfaces#10421
Merged
larsoner merged 12 commits intomne-tools:mainfrom Mar 8, 2022
Merged
Conversation
Modifed slightly from this gist: https://gist.github.com/jbteves/384bfdd3777190f59620c3d988a314fd
agramfort
reviewed
Mar 8, 2022
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
Member
|
@jbteves can you look and see if what I did makes sense and still works for you? If it's good to go, feel free to add a line to |
Member
|
The sphinx windows failure is due to sphinx-gallery/sphinx-gallery#904 . I think we can ignore it for now... |
added 3 commits
March 8, 2022 13:00
…ython into add_get_decimated_surfaces
Contributor
Author
|
Thanks @larsoner ! This makes sense and looks much more efficient, I just did a quick solution for a proof of concept so that's much better. |
larsoner
reviewed
Mar 8, 2022
larsoner
reviewed
Mar 8, 2022
agramfort
approved these changes
Mar 8, 2022
Member
|
@larsoner merge if happy |
Member
|
Thanks @jbteves ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifed slightly from this gist:
https://gist.github.com/jbteves/384bfdd3777190f59620c3d988a314fd
Thanks for contributing a pull request! Please make sure you have read the
contribution guidelines
before submitting.
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
Reference issue
Example: partially closes #9286
What does this implement/fix?
Adds a function that gets the decimated subsurface from a SourceSpaces object.
Additional information
Draft: left some notes in-code for parts I'm unsure of. Appears to work with a local test, but not sure how to integrate an automated test for the maintainer's preference (reference data set? Generate synthetic surfaces and ensure that the result is correct?)