Regarding the API, there is already a test test_output_equiv to which I added the threshold parameter to be tested.
However, I also noticed the False value for adjacency was not tested and indeed there are problems here:
adjacency=False runs only for 1D inputs (which I think is not expected)- for 1D input, the output is always
"indices" whatever is out_type
I guess it is rarely used... Should this be corrected in the same or another PR?
Originally posted by @nfourcau in #12609 (comment)
Regarding the API, there is already a test
test_output_equivto which I added thethresholdparameter to be tested.However, I also noticed the
Falsevalue foradjacencywas not tested and indeed there are problems here:adjacency=Falseruns only for 1D inputs (which I think is not expected)"indices"whatever isout_typeI guess it is rarely used... Should this be corrected in the same or another PR?
Originally posted by @nfourcau in #12609 (comment)