Skip to content

missed deprecation changes #12273

@drammock

Description

@drammock

I stumbled upon this today, which should have changed between 1.5 and 1.6:

dep_msg = (
"The default for pick_channels will change from ordered=False to "
"ordered=True in 1.5"
)
if len(missing):
if ordered is None:
warn(
f"{dep_msg} and this will result in an error because the "
f"following channel names are missing:\n{missing}\n"
"Either fix your included names or explicitly pass "
"ordered=False.",
FutureWarning,
)
elif ordered:
raise ValueError(
"Missing channels from ch_names required by "
"include:\n%s" % (missing,)
)
if not ordered:
out_sel = np.unique(sel)
if ordered is None and not np.array_equal(out_sel, sel):
warn(
f"{dep_msg} and this will result in a change of behavior "
"because the resulting channel order will not match. Either "
"use a channel order that matches your instance or "
"pass ordered=False.",
FutureWarning,
)

change probably should be backported. I've tweaked the release wiki's deprecation section to include a reminder about searching for FutureWarnings

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions