Skip to content

API: Use annotations for read_raw_egi events rather than synthetic channel  #12262

@larsoner

Description

@larsoner

In #4017 (comment) we added RawEGI.event_id which disappears on round-trip. This is due to not knowing which/how many DIN channels will get triggers.

Nowadays we should use Annotations rather than synthesize an event channel I think. Not sure if it's worth keeping the event channel synthesizing around for backward compat or deprecating it. But either way adding the annotations will make it possible for people to use modern code rather than relying on raw.event_id here.

See also discourse for discussion.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions