Skip to content

fix Spectrum init in tutorial#11921

Merged
larsoner merged 1 commit intomne-tools:mainfrom
drammock:fix-circle
Aug 24, 2023
Merged

fix Spectrum init in tutorial#11921
larsoner merged 1 commit intomne-tools:mainfrom
drammock:fix-circle

Conversation

@drammock
Copy link
Copy Markdown
Member

#11769 introduced a new remove_dc param to Spectrum.__init__ but we forgot to add it to the relevant tutorial.

@drammock
Copy link
Copy Markdown
Member Author

cc @chapochn. This was caught by our overnight "run all tutorials" job. FYI to have caught this in advance we probably should have done git grep "Spectrum\("

@larsoner
Copy link
Copy Markdown
Member

@drammock can you touch the problematic example so CircleCI green here means we're good?

@chapochn
Copy link
Copy Markdown
Contributor

cc @chapochn. This was caught by our overnight "run all tutorials" job. FYI to have caught this in advance we probably should have done git grep "Spectrum\("

Thanks for catching that! Yeah, sorry didn't know realize that this object would be accessed directly in tutorials.

Maybe we should point to this tutorial in the definition (given the current prohibitive warning):
https://mne.tools/stable/generated/mne.time_frequency.Spectrum.html#mne.time_frequency.Spectrum

@chapochn
Copy link
Copy Markdown
Contributor

chapochn commented Aug 24, 2023

Ah I see the tutorial is already linked, maybe then just update the prohibitive statement?

@drammock
Copy link
Copy Markdown
Member Author

@drammock can you touch the problematic example so CircleCI green here means we're good?

the tutorial is already changed (the only file that is changed) :)

@drammock
Copy link
Copy Markdown
Member Author

@larsoner larsoner merged commit beb52bd into mne-tools:main Aug 24, 2023
@larsoner
Copy link
Copy Markdown
Member

Thanks @drammock @chapochn !

@drammock drammock deleted the fix-circle branch August 24, 2023 20:00
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants