TST: Refactor _interactor

GuillaumeFavelier · GuillaumeFavelier · commit b819d02f119a · 2021-03-10T16:24:07.000+01:00
diff --git a/mne/viz/_brain/_brain.py b/mne/viz/_brain/_brain.py
@@ -618,10 +618,7 @@ def setup_time_viewer(self, time_viewer=True, show_traces=True):
         self.keys = ('fmin', 'fmid', 'fmax')
 
         # Direct access parameters:
-        if self.notebook:
-            self.interactor = None
-        else:
-            self.interactor = self.plotter.interactor
+        self.interactor = self._renderer._interactor
 
         # Derived parameters:
         self.playback_speed = self.default_playback_speed_value
@@ -1172,11 +1169,7 @@ def _configure_playback(self):
     def _configure_mplcanvas(self):
         ratio = (1 - self.interactor_fraction) / self.interactor_fraction
         dpi = self._renderer._window_get_dpi()
-        if self.notebook:
-            w, h = self.plotter.window_size
-        else:
-            w = self.interactor.geometry().width()
-            h = self.interactor.geometry().height()
+        w, h = self._renderer._window_get_size()
         h /= ratio
         # Get the fractional components for the brain and mpl
         self.mpl_canvas = MplCanvas(self, w / dpi, h / dpi, dpi,
@@ -3150,8 +3143,8 @@ def frame_callback(frame, n_frames):
                     self.status_msg.repaint()
 
                 # set cursor to busy
-                default_cursor = self.interactor.cursor()
-                self.interactor.setCursor(QCursor(Qt.WaitCursor))
+                default_cursor = self._renderer._window_get_cursor()
+                self._renderer._window_set_cursor(QCursor(Qt.WaitCursor))
 
                 try:
                     self._save_movie(
@@ -3163,7 +3156,7 @@ def frame_callback(frame, n_frames):
                 except (Exception, KeyboardInterrupt):
                     warn('Movie saving aborted:\n' + traceback.format_exc())
                 finally:
-                    self.interactor.setCursor(default_cursor)
+                    self._renderer._window_set_cursor(default_cursor)
         else:
             self._save_movie(filename, time_dilation, tmin, tmax,
                              framerate, interpolation, codec,
diff --git a/mne/viz/backends/_abstract.py b/mne/viz/backends/_abstract.py
@@ -593,3 +593,15 @@ def _window_initialize(self, func=None):
     @abstractmethod
     def _window_get_dpi(self):
         pass
+
+    @abstractmethod
+    def _window_get_size(self):
+        pass
+
+    @abstractmethod
+    def _window_get_cursor(self):
+        pass
+
+    @abstractmethod
+    def _window_set_cursor(self, cursor):
+        pass
diff --git a/mne/viz/backends/_notebook.py b/mne/viz/backends/_notebook.py
@@ -217,10 +217,20 @@ def _status_bar_add_progress_bar(self, stretch=0):
 class _IpyWindow(_AbstractWindow):
     def _window_initialize(self, func=None):
         self._window = None
+        self._interactor = None
 
     def _window_get_dpi(self):
         return 96
 
+    def _window_get_size(self):
+        return self.figure.plotter.window_size
+
+    def _window_get_cursor(self):
+        pass
+
+    def _window_set_cursor(self, cursor):
+        pass
+
 
 class _IpyWidget(_AbstractWidget):
     def set_value(self, value):
diff --git a/mne/viz/backends/_qt.py b/mne/viz/backends/_qt.py
@@ -318,12 +318,24 @@ def _status_bar_add_progress_bar(self, stretch=0):
 class _QtWindow(_AbstractWindow):
     def _window_initialize(self, func=None):
         self._window = self.figure.plotter.app_window
+        self._interactor = self.figure.plotter.interactor
         if func is not None:
             self._window.signal_close.connect(func)
 
     def _window_get_dpi(self):
         return self._window.windowHandle().screen().logicalDotsPerInch()
 
+    def _window_get_size(self):
+        w = self._interactor.geometry().width()
+        h = self._interactor.geometry().height()
+        return (w, h)
+
+    def _window_get_cursor(self):
+        return self._interactor.cursor()
+
+    def _window_set_cursor(self, cursor):
+        self._interactor.setCursor(cursor)
+
 
 class _QtWidget(_AbstractWidget):
     def set_value(self, value):
