Write optical density data in SNIRF format#511
Merged
rob-luke merged 10 commits intomne-tools:mainfrom May 3, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 95.44% 95.47% +0.02%
==========================================
Files 69 69
Lines 2791 2830 +39
Branches 400 403 +3
==========================================
+ Hits 2664 2702 +38
Misses 63 63
- Partials 64 65 +1
|
Member
|
Great PR @florin-pop. I made some suggestions that I think will simplify the code and slightly boost test coverage. Could you please check if they actually work? And add a changelog entry then ping us for a review/merge. Thanks! |
rob-luke
requested changes
May 2, 2023
Collaborator
Author
|
@larsoner I noticed that after you merged mne-tools/mne-python#11665 this line started failing in CI Should we replace it with: with pytest.raises(ValueError, match='could not be picked'):? |
Collaborator
Author
|
I was thinking of doing something like: but I'm not sure |
Member
|
I would use |
Member
|
Tests are green. Thanks @florin-pop @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456
Write optical density data in SNIRF format.
Example usage:
Contributed with ❤️ by AE Studio