requirePropFactory updates#23
Merged
mnajdova merged 2 commits intofeat/grid-migrate-to-emotionfrom Jan 14, 2021
Merged
Conversation
Owner
mnajdova
commented
Jan 14, 2021
- I have followed (at least) the PR section of the contributing guide.
1 task
oliviertassinari
approved these changes
Jan 14, 2021
eps1lon
reviewed
Jan 14, 2021
Comment on lines
+15
to
+22
| const defaultPropType = Component?.propTypes?.[propFullNameSafe]; | ||
| let defaultPropTypeVal = null; | ||
|
|
||
| if(defaultPropType) { | ||
| console.log("Default prop type existed"); | ||
| defaultPropTypeVal = defaultPropType(props, propName, componentName, location, propFullName) | ||
| } | ||
|
|
There was a problem hiding this comment.
Properties in Component.propTypes (e.g. PropTypes.string) are referred to as "type checkers" or "validators". And then you could name their return value validatorResult or typeCheckerResult.
The current naming seems overly generic to me. Especially looking at the return statement "return defaultPropTypeVal".
Owner
Author
There was a problem hiding this comment.
Renamed to defaultTypeChecker & defaultTypeCheckerResult. I use the default prefix, as we are not defining a new type checking for the property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.