Include locale.h on any GNU libc platform#925
Merged
ddennedy merged 1 commit intomltframework:masterfrom Apr 17, 2024
pinotree:locale-glibc
Merged
Include locale.h on any GNU libc platform#925ddennedy merged 1 commit intomltframework:masterfrom pinotree:locale-glibc
ddennedy merged 1 commit intomltframework:masterfrom
pinotree:locale-glibc
Conversation
locale.h & locale_t are implemented by GNU libc (at least), so any OS based on it has them; hence, extend the check to use __GLIBC__ as alternative to __linux__. Updates commit 7d82553 by bringing __GLIBC__ back in use. Fixes commit 2a2ff9e by dropping the check for macOS (__APPLE__) when GNU libc is available; there is no GNU libc on macOS, so that check is always false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locale.h&locale_tare implemented by GNU libc (at least), so any OS based on it has them; hence, extend the check to use__GLIBC__as alternative to__linux__.Updates commit 7d82553 by bringing
__GLIBC__back in use.Fixes commit 2a2ff9e by dropping the check for macOS (
__APPLE__) when GNU libc is available; there is no GNU libc on macOS, so that check is always false.