-
Notifications
You must be signed in to change notification settings - Fork 293
[Pipelines] Prevent deprecation warning when using project.run() for KFP workflows #9195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/api/utils/builder.py # tests/api/utils/test_builder.py
liranbg
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes a deprecation warning that appeared when using
project.run()with remote KFP workflows, even when no experiment parameter was provided. The warning was triggered because internal code paths were auto-generating experiment names.This PR:
Prevents warnings when using
project.run()Moves experiment name enrichment and normalization to the server side only
Maintains backward compatibility with the old behavior (
name or workflow_spec.name+ project prefix)Ensures the deprecation warning only appears when users explicitly pass the experiment parameter
🛠️ Changes Made
Changed
_KFPRunner.run()to passexperiment=Noneinstead of auto-generatingexperiment=name or workflow_spec.nameAdded logic to pass workflow name (name or workflow_spec.name) as run parameter so server can use it as fallback for experiment name
✅ Checklist
🧪 Testing
🔗 References
🚨 Breaking Changes?