[Tests] Make pod log collection opt-in via pytest marker (ML-11964) #9194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pod log collection on test failure was collecting too much data.
Make it opt-in by requiring @pytest.mark.collect_pod_logs marker.
Tests that want log collection on failure can add the marker:
@pytest.mark.collect_pod_logs
def test_something(self):
...
assaf758
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Make pod log collection on test failure opt-in instead of collecting for all tests. This reduces noise from excessive log collection during system tests.
Tests that want log collection on failure now need to add the
@pytest.mark.collect_pod_logsmarker.🛠️ Changes Made
collect_pod_logspytest marker in_collect_pod_logs_on_failure()pyproject.tomlto avoid pytest warnings✅ Checklist
🧪 Testing
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes
Usage example: