[Hub] Support adding hub steps to the serving graph #9133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesh0812
reviewed
Dec 31, 2025
| @pytest.mark.skip( | ||
| reason="Remove this marker after steps are added to the functions repo" | ||
| ) | ||
| def test_serving_with_hub_steps(self): |
Contributor
There was a problem hiding this comment.
please lets have the same test also as sys test
Member
There was a problem hiding this comment.
Well since it's uses an external resource (hub step) I think that it's enough to use just integ test.
davesh0812
reviewed
Dec 31, 2025
Eyal-Danieli
approved these changes
Jan 5, 2026
Eyal-Danieli
reviewed
Jan 8, 2026
Member
Eyal-Danieli
left a comment
There was a problem hiding this comment.
Nice, please add __init__.py file under the new hub system test dir
Comment on lines
22
to
24
| class Echo(BaseClass): | ||
| def __init__(self, name=None): | ||
| self.name = name |
Member
There was a problem hiding this comment.
just a recommendation
class Echo(BaseClass):
def __init__(self, context, name=None):
super().__init__(context=context, name=name)
Eyal-Danieli
approved these changes
Jan 11, 2026
Eyal-Danieli
approved these changes
Jan 11, 2026
Member
Eyal-Danieli
left a comment
There was a problem hiding this comment.
just resolve conflicts :)
# Conflicts: # mlrun/runtimes/nuclio/serving.py
Eyal-Danieli
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add support to adding hub steps to the serving graph by implement infra
HubTaskStepand modifying the methods for adding steps to the graph🛠️ Changes Made
HubTaskStepkind, which inherits fromTaskStepand implements aninit_objectwhich initialize the actual step from the dynamically imported hub step code.params_to_step()by adding another branch to createHubTaskStepin case theclass_nameparameter is a hub URL.ServingRuntime'sdeploy()andto_job()methods by adding a step of adding the requirements of the local steps with the requirements of the function✅ Checklist
🧪 Testing
New integration test was added to cover the changes in this PR.
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes