Skip to content

Conversation

@pioardi
Copy link
Contributor

@pioardi pioardi commented Dec 17, 2025

πŸ“ Description

Enabling system test open source trigger on PR to development branch.


πŸ› οΈ Changes Made


βœ… Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

πŸ§ͺ Testing


πŸ”— References

  • Ticket link:
  • Design docs links:
  • External links:

🚨 Breaking Changes?

  • Yes (explain below)
  • No

πŸ”οΈ Additional Notes

@pioardi pioardi changed the title [CI]Add pull request trigger for system tests workflow [CI] Add pull request trigger for system tests workflow Dec 17, 2025
@pioardi pioardi marked this pull request as ready for review December 17, 2025 14:10
@pioardi pioardi requested a review from liranbg as a code owner December 17, 2025 14:10
@pioardi pioardi requested a review from assaf758 December 17, 2025 14:31
Copy link
Member

@assaf758 assaf758 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting excited :-)

Few comments:

  1. The trigger should be on push, not on pull_request (so the developer can fix any found issue in follow-up push)
  2. I think we want it only on release branch (at least for starters): development, 1.10.x ..
  3. Optimization (worthwhile if not too hard): on push, cancel previous run on this PR, if exist

@pioardi pioardi merged commit 4db7842 into development Dec 18, 2025
26 of 28 checks passed
@pioardi
Copy link
Contributor Author

pioardi commented Dec 18, 2025

Getting excited :-)

Few comments:

  1. The trigger should be on push, not on pull_request (so the developer can fix any found issue in follow-up push)
  2. I think we want it only on release branch (at least for starters): development, 1.10.x ..
  3. Optimization (worthwhile if not too hard): on push, cancel previous run on this PR, if exist

For me Point 1 should be when PR is open, else we trigger too many of those pipelines. They can open a draft PR if they want to trigger the pipeline a bit before.
Point 2 I agree 100% we are triggering it only for development, if we have a naming convention for release branches we can add them ( but we don' t, so please list branches we want to add )
Point 3 is a good idea, I can implement it on another PR

@assaf758
Copy link
Member

Getting excited :-)
Few comments:

  1. The trigger should be on push, not on pull_request (so the developer can fix any found issue in follow-up push)
  2. I think we want it only on release branch (at least for starters): development, 1.10.x ..
  3. Optimization (worthwhile if not too hard): on push, cancel previous run on this PR, if exist

For me Point 1 should be when PR is open, else we trigger too many of those pipelines. They can open a draft PR if they want to trigger the pipeline a bit before. Point 2 I agree 100% we are triggering it only for development, if we have a naming convention for release branches we can add them ( but we don' t, so please list branches we want to add ) Point 3 is a good idea, I can implement it on another PR

For point-1 - that's why added more runners, so we can run on every push (stats is average of 40 push per day, max of 10 concurrent).
It will help to have point-3 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants