Skip to content

[Deprecations] Remove deprecated limit param in list artifacts #9073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomerShor merged 4 commits into from
Jan 5, 2026
Merged

[Deprecations] Remove deprecated limit param in list artifacts #9073

TomerShor merged 4 commits into from
Jan 5, 2026

Conversation

@Yacouby
Copy link
Member

@Yacouby Yacouby commented Dec 17, 2025

📝 Description

Remove the deprecated limit parameter in list_artifacts

🛠️ Changes Made

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

🔗 References

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@Yacouby Yacouby marked this pull request as ready for review December 17, 2025 14:49
elbamit
elbamit requested changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@elbamit elbamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. What about these:

@Yacouby
Copy link
Member Author

Yacouby commented Jan 4, 2026

Great. What about these:

These should stay, as we do not pass page and page_size here, which should replace the limit param ( as in list_artifacts of artifacts_v2 )

@TomerShor
Copy link
Member

TomerShor commented Jan 5, 2026

Backwards compatibility tests fail because deprecated query params were removed - which is OK.

@TomerShor TomerShor merged commit c512081 into mlrun:development Jan 5, 2026
12 of 13 checks passed
@Yacouby Yacouby deleted the ML-11606 branch January 5, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liranbg liranbg liranbg approved these changes

@elbamit elbamit elbamit approved these changes

@TomerShor TomerShor TomerShor approved these changes

@yaelgen yaelgen Awaiting requested review from yaelgen yaelgen is a code owner

@moranbental moranbental Awaiting requested review from moranbental moranbental is a code owner

@quaark quaark Awaiting requested review from quaark quaark is a code owner

Assignees

No one assigned

Labels

area/api area/framework area/sdk area/server area/tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yacouby @TomerShor @liranbg @elbamit