Skip to content

Conversation

@elbamit
Copy link
Contributor

@elbamit elbamit commented Dec 16, 2025

📝 Description

When storing auth secret (like during import mlrun), if the secret exist and we have a new secret (same name) to store, we go to the flow of updating it instead of creating it.
There is a bug during secret update where namespace=None because we miss the namespace resolvement like here feb28bd#diff-61dbf2e7115b2faa269a79d1939db5eeebbc97204540b745b15db12133c49261R736


🛠️ Changes Made

  • refactor _update_secret to resolve namespace

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

reproduced the bug, then patched the system and saw it resolved.

🔗 References

  • Ticket link:
  • Design docs links:
  • External links:

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@liranbg liranbg merged commit cc6a1c5 into mlrun:development Dec 17, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants