[Auth] Change user token auth secret naming convention #8986
+99
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbamit
reviewed
Nov 30, 2025
| ) | ||
|
|
||
| create = False | ||
| secret_data = self._encode_user_token(token_name, token, expiration) |
Contributor
There was a problem hiding this comment.
Encoding here becomes useless if the code doesn't access any of the if conditions below. You can encode only if you're going to create/update
elbamit
approved these changes
Nov 30, 2025
TomerShor
reviewed
Nov 30, 2025
Comment on lines
+1211
to
+1213
| create = True | ||
|
|
||
| if create: |
Member
There was a problem hiding this comment.
why not keep it in the if not k8s_secret: clause?
Member
Author
There was a problem hiding this comment.
just for explicitness - thought it make it a bit more readable
TomerShor
reviewed
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The current implementation assumes username and token name part of the secret name - which can lead to k8s validation issues when username contains @ or token name has some
_characters which is not k8s valid for secret names.🛠️ Changes Made
✅ Checklist
🧪 Testing
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes