[Security] Ensure files are not opened from the API during secret_sources handling #8729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR ensures that the following (false positive, see related Jira ticket) vulnerability https://github.com/mlrun/mlrun/security/code-scanning/135 will not happen. It will raise a runtimeError if changed.
The PR ensures that for adding source with
kind="file", you need to be outside of the API to ensure you're not opening files inside it.🛠️ Changes Made
add_source()function to raise an error ifkind=fileand running inside the api✅ Checklist
🧪 Testing
Manual test that helper function is correct, and that the flow that reach add_source do not enter
kind=filewhen running from the API🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes