[KFP] Format KFP runs concurrently instead of one by one #8662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mdelman/mlrun into adamd/add_concurrent_pipeline_format
…oncurrent_pipeline_format
Yacouby
requested changes
Dec 1, 2025
| try: | ||
| formatted_runs.append(future.result()) | ||
| except Exception: | ||
| mlrun.utils.logger.warning( |
Member
There was a problem hiding this comment.
shouldn't this be error and not warning ?
| run=run, | ||
| """ | ||
| Submit formatting tasks concurrently and emit results in discovery order. | ||
| """ |
Member
There was a problem hiding this comment.
worth to add a check at the beginning if runs is empty then return
| self._format_run( | ||
| run=run, | ||
| """ | ||
| Submit formatting tasks concurrently and emit results in discovery order. |
Member
There was a problem hiding this comment.
add more doc explaining the use of the semaphore here and the max_workers
…mdelman/mlrun into adamd/add_concurrent_pipeline_format
Yacouby
approved these changes
Dec 1, 2025
liranbg
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Introduced concurrent formatting for runs and aligned tests/mocks with the new flow.
🛠️ Changes Made
Pipelines._format_runs_concurrently(...)usingThreadPoolExecutor(with optional boundedSemaphore) to format runs in parallel while preserving discovery order and skipping per-run failures with a warning.list_pipelines(...)now invokes the concurrent formatter for each streamed page.✅ Checklist
🧪 Testing
experiment_idsare present vs. absent.🔗 References
🚨 Breaking Changes?