Skip to content

Spatial Dropout layer#2564

Merged
sreenikSS merged 10 commits intomlpack:masterfrom
iamshnoo:spatial_dropout
Aug 28, 2020
Merged

Spatial Dropout layer#2564
sreenikSS merged 10 commits intomlpack:masterfrom
iamshnoo:spatial_dropout

Conversation

@iamshnoo
Copy link
Copy Markdown
Member

@iamshnoo iamshnoo commented Aug 11, 2020

Spatial Dropout Layer

To compare PyTorch/numpy implementation with mlpack/armadillo implementation of the functionality, check this Google Colab notebook.

types_of_dropout

@iamshnoo
Copy link
Copy Markdown
Member Author

In the test case, I am using arma::arma_rng::set_seed(0) so that the second channel can specifically be dropped out (as in the image above). That allows me to directly compare the output with an expected matrix. This works when I test it on Mac and Linux. However, I noticed that the Windows build failed for the last commit when checking this. I think arma::arma_rng::set_seed(0) is not working the way I expect it to on the Windows machine. Any clues as to how I can go about resolving this? Thanks!

@zoq
Copy link
Copy Markdown
Member

zoq commented Aug 16, 2020

In the test case, I am using arma::arma_rng::set_seed(0) so that the second channel can specifically be dropped out (as in the image above). That allows me to directly compare the output with an expected matrix. This works when I test it on Mac and Linux. However, I noticed that the Windows build failed for the last commit when checking this. I think arma::arma_rng::set_seed(0) is not working the way I expect it to on the Windows machine. Any clues as to how I can go about resolving this? Thanks!

It's not guaranteed that the random number is the same across all systems, the only workaround I can see is to check all possible solutions, if that makes sense?

@sreenikSS
Copy link
Copy Markdown
Contributor

sreenikSS commented Aug 25, 2020

This looks alright. I'll merge it if you don't have anything else to add (take care of the conflicts as well).

Copy link
Copy Markdown
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sreenikSS sreenikSS merged commit f99561e into mlpack:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants