Merged
Conversation
jeffin143
approved these changes
Mar 23, 2020
Member
jeffin143
left a comment
There was a problem hiding this comment.
Finally , all green ✔️ after many days
Can we quickly merge this
favre49
approved these changes
Mar 23, 2020
Member
favre49
left a comment
There was a problem hiding this comment.
Great, it passes. I'll go ahead and merge this.
Closed
This was referenced Jun 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the findings in Homebrew/homebrew-core#52003 and Conrad's workaround in https://gitlab.com/conradsnicta/armadillo-code/-/commit/0166bc036c5c6754402f60b0b2ffeb0914ea2939.
In essence, the breakages in the OS X builds are caused by HDF5 updating from 1.10 to 1.12 and this is a reverse-incompatible change (!). So this replicates Conrad's fix for new versions of Armadillo, which is to force the HDF5 1.8 API. We do the same here, since it will still be needed for older versions of Armadillo.
See also #2320 and related issues.
Let's see if it builds successfully...