Closed
Conversation
Member
Author
|
Hmm, The test still failed, I think this warrants more attention. |
Contributor
|
Hi @kartikdutt18 , quick & nice observation👍. I submitted a PR the day before yesterday, but there was no LoadSaveTest failure. Also no new PR merge. So why? I don't get it... |
Member
Author
|
Hi @bisakhmondal, this might be because of new version of dependency that mlpack uses. Currently working on finding that out. Locally it works fine. |
Member
Author
|
Yup it's related to a dependency, I ran update across all my dependencies and finally got the test to fail. |
zoq
reviewed
Mar 10, 2020
Member
zoq
left a comment
There was a problem hiding this comment.
I guess this could work as a quick fix.
Co-Authored-By: Marcus Edel <marcus.edel@fu-berlin.de>
Member
Author
|
Closing this in lieu of #2278. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So across all PRs yesterday LoadSaveTest Failed. I tried it on my Mac (OS Sierra and Catalina) one with Julia bindings and the other with python bindings. None of them failed. So I just want to check if the tests fail. Hopefully they don't and I close this :) .
Thanks.